[TESTING PR] chore: test solana ci without the test environment variable - #83
Closed
Battambang wants to merge 1 commit into
Closed
Conversation
jeremytsng
pushed a commit
that referenced
this pull request
Aug 5, 2026
## Explanation This PR adds MetaMask analytics helpers for transaction/security events and wires transaction lifecycle tracking into selected Stellar Snap transaction flows, while centralizing the MetaMask origin string. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTING PR to try aligning Solana CI tests execution repo pattern.
This pull request includes updates to the workflow configuration and test utilities to improve consistency and simplify test setup. The main changes are focused on standardizing environment variables for API endpoints during builds and generalizing test utility values.
Workflow and environment improvements:
LOCAL_API_BASE_URLduring the build process in.github/workflows/lint-build-test.yml, ensuring consistent test environments.snap.manifest.jsonfiles in any package after test builds, rather than only the Solana package, improving generality and preventing accidental changes.Test utility update:
TEST_ORIGINvalue inutils.tsfrom'http://localhost:3000'to'metamask', likely to better reflect the expected test environment.